runInLinuxVM: add hostPkgs
#352946
Open
runInLinuxVM: add hostPkgs
#352946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixscheinost
commented
Nov 1, 2024
| # using over `buildPackages` as currently `nix-build -E '(import <nixpkgs> { }).pkgsCross.aarch64-multiplatform.buildPackages.qemu_kvm'` | ||
| # fails on aarch64-darwin with `error: Don't know how to run aarch64-unknown-linux-gnu executables.` | ||
| , hostPkgs ? pkgs.buildPackages | ||
|
|
There was a problem hiding this comment.
Overall there are 4 packages which need to comre from hostPkgs:
qemu_kvmbashforbuildercoreutilsforrun-vmwriteTextforrun-vm
felixscheinost
commented
Nov 1, 2024
| builder = "${bash}/bin/sh"; | ||
| system = hostPkgs.system; | ||
| requiredSystemFeatures = if !hostPkgs.stdenv.isDarwin then [ "kvm" ] else []; | ||
| builder = "${hostPkgs.bash}/bin/sh"; | ||
| args = ["-e" (vmRunCommand qemuCommandLinux)]; |
There was a problem hiding this comment.
Changing system here is a hack. This would probably go away when using pkgsCross properly which currently doesn't work due to qemu_kvm (see error in PR).
This change is a possible fix for NixOS#73470. Similar to NixOS change `virtualisation.host.pkgs` (NixOS#180222). ## Why `hostPkgs` over `buildPackages` I would've preferred to use the cross-compilation targets but that didn't work. For example, ideally the following would work on Darwin: ```nix with (import <nixpkgs> { }).pkgsCross.aarch64-multiplatform; vmTools.runInLinuxVM hello ``` That would make sense to me: I want to run `aarch64-multiplatform` `hello` in an `aarch64-linux` VM but build, i.e. run the VM on a Darwin build-system. But this fails very early. Evaluating the following: ```nix (import <nixpkgs> { }).pkgsCross.aarch64-multiplatform.buildPackages.qemu_kvm' ``` fails with this error: > error: Don't know how to run aarch64-unknown-linux-gnu executables. Could someone more knowledgeable about the cross-compilation system explain why this is the case? ## How to use ```nix let pkgs = import <nixpkgs> { system = "aarch64-linux"; }; vmTools = pkgs.vmTools.override { hostPkgs = import <nixpkgs> { }; }; in vmTools.runInLinuxVM pkgs.hello ```
felixscheinost
force-pushed
the
runInLinuxVM-add-hostPkgs
branch
from
d6ba71a
to
dc0026e
Compare
felixscheinost
added a commit
to felixscheinost/disko
that referenced
this pull request
Nov 1, 2024
Depends on open nixpkgs PR NixOS/nixpkgs#352946
Artturin
reviewed
Nov 2, 2024
There was a problem hiding this comment.
That would make sense to me: I want to run
aarch64-multiplatformhelloin anaarch64-linuxVM but build, i.e. run the VM on a Darwin build-system.But this fails very early. Evaluating the following:
(import <nixpkgs> { }).pkgsCross.aarch64-multiplatform.buildPackages.qemu_kvm'
There's no qemu-user for darwin
nixpkgs/lib/systems/default.nix
Lines 289 to 290 in 068b0aa
Package ‘qemu-user-9.1.1’ in ./pkgs/applications/virtualization/qemu/default.nix:318 is not available on the requested hostPlatformwhich we need for cross-compiling
gobject-introspection
Maybe a conditional wrong somewhere
nix-repl> pkgsCross.aarch64-multiplatform.buildPackages.graphene
error:
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:9:12:
8|
9| strict = derivationStrict drvAttrs;
| ^
10|
… while evaluating derivation 'graphene-1.10.8'
whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'postPatch' of derivation 'graphene-1.10.8'
at /home/artturin/nixgits/my-nixpkgs/pkgs/development/libraries/graphene/default.nix:95:3:
94|
95| postPatch = ''
| ^
96| patchShebangs tests/gen-installed-test.py
… from call site
at /home/artturin/nixgits/my-nixpkgs/pkgs/development/libraries/graphene/default.nix:97:8:
96| patchShebangs tests/gen-installed-test.py
97| '' + lib.optionalString withIntrospection ''
| ^
98| PATH=${python3.withPackages (pp: [ pp.pygobject3 pp.tappy ])}/bin:$PATH patchShebangs tests/introspection.py
… while calling 'optionalString'
at /home/artturin/nixgits/my-nixpkgs/lib/strings.nix:678:5:
677| cond:
678| string: if cond then string else "";
| ^
679|
… while calling the 'getAttr' builtin
at <nix/derivation-internal.nix>:19:19:
18| value = commonAttrs // {
19| outPath = builtins.getAttr outputName strict;
| ^
20| drvPath = strict.drvPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:9:12:
8|
9| strict = derivationStrict drvAttrs;
| ^
10|
… while evaluating derivation 'python3-3.12.7-env'
whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'passAsFile' of derivation 'python3-3.12.7-env'
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/trivial-builders/default.nix:60:9:
59| inherit buildCommand name;
60| passAsFile = [ "buildCommand" ]
| ^
61| ++ (derivationArgs.passAsFile or [ ]);
… while evaluating the attribute 'passAsFile'
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:87:5:
86| # XXX: The size is somewhat arbitrary
87| passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
| ^
88| }
… while evaluating a branch condition
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:87:18:
86| # XXX: The size is somewhat arbitrary
87| passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
| ^
88| }
… in the argument of the not operator
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:87:48:
86| # XXX: The size is somewhat arbitrary
87| passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
| ^
88| }
… while calling the 'lessThan' builtin
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:87:48:
86| # XXX: The size is somewhat arbitrary
87| passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
| ^
88| }
… while calling the 'stringLength' builtin
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:87:21:
86| # XXX: The size is somewhat arbitrary
87| passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
| ^
88| }
… while calling the 'toJSON' builtin
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:82:12:
81| nativeBuildInputs buildInputs;
82| pkgs = builtins.toJSON chosenOutputs;
| ^
83| extraPathsFrom = lib.optional includeClosures (writeClosure pathsForClosure);
… while calling the 'map' builtin
at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:56:19:
55| let
56| chosenOutputs = map (drv: {
| ^
57| paths =
… from call site
at /home/artturin/nixgits/my-nixpkgs/pkgs/development/interpreters/python/wrapper.nix:20:13:
19| env = let
20| paths = requiredPythonModules (extraLibs ++ [ python ] ) ;
| ^
21| pythonPath = "${placeholder "out"}/${python.sitePackages}";
… while calling 'requiredPythonModules'
at /home/artturin/nixgits/my-nixpkgs/pkgs/development/interpreters/python/python-packages-base.nix:54:27:
53| # Get list of required Python modules given a list of derivations.
54| requiredPythonModules = drvs: let
| ^
55| modules = lib.filter hasPythonModule drvs;
… while calling the 'foldl'' builtin
at /home/artturin/nixgits/my-nixpkgs/pkgs/development/interpreters/python/python-packages-base.nix:56:6:
55| modules = lib.filter hasPythonModule drvs;
56| in lib.unique ([python] ++ modules ++ lib.concatLists (lib.catAttrs "requiredPythonModules" modules));
| ^
57|
… while calling anonymous lambda
at /home/artturin/nixgits/my-nixpkgs/lib/lists.nix:1793:25:
1792| */
1793| unique = foldl' (acc: e: if elem e acc then acc else acc ++ [ e ]) [];
| ^
1794|
… while evaluating a branch condition
at /home/artturin/nixgits/my-nixpkgs/lib/lists.nix:1793:28:
1792| */
1793| unique = foldl' (acc: e: if elem e acc then acc else acc ++ [ e ]) [];
| ^
1794|
… while calling the 'elem' builtin
at /home/artturin/nixgits/my-nixpkgs/lib/lists.nix:1793:31:
1792| */
1793| unique = foldl' (acc: e: if elem e acc then acc else acc ++ [ e ]) [];
| ^
1794|
… while evaluating the attribute 'outPath'
at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:366:7:
365| drvPath = assert condition; drv.drvPath;
366| outPath = assert condition; drv.outPath;
| ^
367| };
… while evaluating the attribute 'outPath'
at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:366:7:
365| drvPath = assert condition; drv.drvPath;
366| outPath = assert condition; drv.outPath;
| ^
367| };
… while calling the 'getAttr' builtin
at <nix/derivation-internal.nix>:19:19:
18| value = commonAttrs // {
19| outPath = builtins.getAttr outputName strict;
| ^
20| drvPath = strict.drvPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:9:12:
8|
9| strict = derivationStrict drvAttrs;
| ^
10|
… while evaluating derivation 'python3.12-pygobject-3.50.0'
whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'propagatedBuildInputs' of derivation 'python3.12-pygobject-3.50.0'
at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:390:7:
389| depsHostHostPropagated = elemAt (elemAt propagatedDependencies 1) 0;
390| propagatedBuildInputs = elemAt (elemAt propagatedDependencies 1) 1;
| ^
391| depsTargetTargetPropagated = elemAt (elemAt propagatedDependencies 2) 0;
… while calling the 'getAttr' builtin
at <nix/derivation-internal.nix>:19:19:
18| value = commonAttrs // {
19| outPath = builtins.getAttr outputName strict;
| ^
20| drvPath = strict.drvPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:9:12:
8|
9| strict = derivationStrict drvAttrs;
| ^
10|
… while evaluating derivation 'gobject-introspection-wrapped-1.82.0'
whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'depsTargetTargetPropagated' of derivation 'gobject-introspection-wrapped-1.82.0'
at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:391:7:
390| propagatedBuildInputs = elemAt (elemAt propagatedDependencies 1) 1;
391| depsTargetTargetPropagated = elemAt (elemAt propagatedDependencies 2) 0;
| ^
392|
… while calling the 'getAttr' builtin
at <nix/derivation-internal.nix>:19:19:
18| value = commonAttrs // {
19| outPath = builtins.getAttr outputName strict;
| ^
20| drvPath = strict.drvPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:9:12:
8|
9| strict = derivationStrict drvAttrs;
| ^
10|
… while evaluating derivation 'gobject-introspection-aarch64-unknown-linux-gnu-1.82.0'
whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'mesonFlags' of derivation 'gobject-introspection-aarch64-unknown-linux-gnu-1.82.0'
at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:562:7:
561| cmakeFlags = makeCMakeFlags attrs;
562| mesonFlags = makeMesonFlags attrs;
| ^
563| });
… from call site
at /home/artturin/nixgits/my-nixpkgs/pkgs/development/libraries/gobject-introspection/default.nix:114:34:
113| }}"
114| "-Dgi_cross_binary_wrapper=${stdenv.hostPlatform.emulator buildPackages}"
| ^
115| # can't use canExecute, we need prebuilt when cross
… while calling 'emulator'
at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:303:20:
302|
303| emulator = pkgs:
| ^
304| if (final.emulatorAvailable pkgs)
… while calling the 'throw' builtin
at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:306:16:
305| then selectEmulator pkgs
306| else throw "Don't know how to run ${final.config} executables.";
| ^
307|
error: Don't know how to run aarch64-unknown-linux-gnu executables.
I think we need to improve the conditional for this or shift offsets in the python withPackages tree (if they're wrong)
nixpkgs/pkgs/development/libraries/graphene/default.nix
Lines 97 to 98 in b084db8
There's ++ lib.optionals (stdenv.hostPlatform == stdenv.buildPlatform) [ "installedTests" ]; above so for the installed test stuff we probably need that conditional too
There was a problem hiding this comment.
Oh wow, @Artturin thank you so much! What wizardry is that 😄 On your branch I can evaluate qemu_kvm but the build fails. I'm investigating that.
|
Hi @Artturin thanks again for the PR fixing (among other I presume) I experimented a little bit with your branch but I am not sure if using I made similar changes to this PR on top of your branch, just replacing I am sure those can be fixed but the underlying problem is that still all used derivations are different, right? So when using This doesn't just affect what's used for My concern is that this also increases the chance of the result being different on Linux vs Darwin. I think in reality it is a very pragramtic and useful solution to have two instances of Does that make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a possible fix for #73470.
Similar to NixOS change
virtualisation.host.pkgs(#180222).Why
hostPkgsoverbuildPackagesI would've preferred to use the cross-compilation targets but that didn't work.
For example, ideally the following would work on Darwin:
That would make sense to me: I want to run
aarch64-multiplatformhelloin anaarch64-linuxVM but build, i.e. run the VM on a Darwin build-system.But this fails very early.
Evaluating the following:
fails with this error:
Could someone more knowledgeable about the cross-compilation system explain why this is the case?
How to use
TODO
hostPkgsreally makese sense. I'd rather usebuildPackagesand fix the evaluation error forqemu_kvmabove.systemof the derivation is the right thing to do here. I think this would also go away when usingpkgsCross?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.