Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marp-cli: 3.4.0 -> 4.0.0 #352948

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GuillaumeDesforges
Copy link
Contributor

@GuillaumeDesforges GuillaumeDesforges commented Nov 1, 2024

#351203

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GuillaumeDesforges
Copy link
Contributor Author

I switched it to buildNpmPackage, but it gets stuck after script patching
https://github.com/GuillaumeDesforges/nixpkgs/blob/8109150e8d773b115fcdb0ca5d9c2924c59cc9ca/pkgs/tools/typesetting/marp/default.nix

patching script interpreter paths in node_modules
node_modules/chrome-launcher/bin/print-chrome-path.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/jz54v1m0ldqivx5i45q8i05pz5clf842-nodejs-20.18.0/bin/node"
... many others, then it's stuck

and if I kill the nix-build the derivation becomes locked

@GuillaumeDesforges
Copy link
Contributor Author

GuillaumeDesforges commented Nov 2, 2024

From @Chaostheorie on Matrix:

sometimes npm ci gets hung up forever on some network call (based on strace, it is epoll). I haven't had time to investigate it further but it looks like a (missing) timeout issue inside of npm.

https://matrix.to/#/!NhAsaYbbgmzHtXTPQJ:funklause.de/$PRwqo2GeRsw0gam36QCET78_CNBVvMmLEeJdyd0lRDs?via=matrix.org&via=imagisphe.re&via=nixos.dev

I won't be able to look into it right now. If anyone would like to pick this up, feel free to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant