Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootterm: init at 0.5 #352951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bootterm: init at 0.5 #352951

wants to merge 2 commits into from

Conversation

deadbaed
Copy link

@deadbaed deadbaed commented Nov 1, 2024

I started to use nix recently, and wanted to use bootterm when using one of my SBCs. I noticed it was not packaged, so here it is!

Since it is my first contribution, I am sure I missed some things.

Bootterm is a tool to access serial devices with a simple user interface, and uncomplicated keyboard shortcuts.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 1, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 1, 2024
pkgs/by-name/bo/bootterm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bo/bootterm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bo/bootterm/package.nix Outdated Show resolved Hide resolved
@deadbaed
Copy link
Author

deadbaed commented Nov 3, 2024

Thanks for the feedback! Ofborg complains that testVersion is not found.

After grepping testVersion in pkgs/by-name, I see packages importing testers and using testers.testVersion instead.

I'll update my package and wait for Ofborg again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants