Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baddns: 1.1.869 -> 1.3.3 #352973

Merged
merged 1 commit into from
Nov 4, 2024
Merged

baddns: 1.1.869 -> 1.3.3 #352973

merged 1 commit into from
Nov 4, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Nov 1, 2024

Diff: blacklanternsecurity/baddns@refs/tags/v1.1.869...v1.3.3

Changelog: https://github.com/blacklanternsecurity/baddns/releases/tag/v1.3.3

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff

This comment was marked as outdated.

@fabaff fabaff added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 1, 2024
@tjni
Copy link
Contributor

tjni commented Nov 1, 2024

I think this can also be fixed by pulling in blacklanternsecurity/baddns@da0bd74 as a patch until the next release.

@ofalvai
Copy link
Contributor

ofalvai commented Nov 2, 2024

Version 1.3.3 is now tagged, although there is no release page for it. I can confirm it fixes the failing tests.

@fabaff
Copy link
Member Author

fabaff commented Nov 3, 2024

Yupp, the update to 1.3.3 helps a bit with the tests.

@fabaff fabaff changed the title baddns: disable failing tests baddns: 1.1.869 -> 1.3.3 Nov 3, 2024
@fabaff
Copy link
Member Author

fabaff commented Nov 3, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352973


x86_64-linux

✅ 2 packages built:
  • baddns
  • baddns.dist

@fabaff fabaff merged commit ba71991 into NixOS:master Nov 4, 2024
37 of 38 checks passed
@fabaff fabaff deleted the baddns-fix branch November 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants