Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyprgui: init at 0.1.6 #352986

Merged
merged 1 commit into from
Nov 3, 2024
Merged

hyprgui: init at 0.1.6 #352986

merged 1 commit into from
Nov 3, 2024

Conversation

fccapria
Copy link
Member

@fccapria fccapria commented Nov 1, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 2, 2024
Aleksanaa
Aleksanaa reviewed Nov 2, 2024
View reviewed changes
pkgs/by-name/hy/hyprgui/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hy/hyprgui/package.nix Outdated Show resolved Hide resolved
@fccapria
Copy link
Member Author

fccapria commented Nov 2, 2024

Thank you @Aleksanaa !
Just solved.

Aleksanaa
Aleksanaa approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024
@Aleksanaa Aleksanaa merged commit 05f537e into NixOS:master Nov 3, 2024
28 of 29 checks passed
@fccapria fccapria deleted the hyprgui branch November 3, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fccapria @Aleksanaa @wegank