-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itk: Adds RTK remote crate #353018
base: master
Are you sure you want to change the base?
itk: Adds RTK remote crate #353018
Conversation
My bad i forgot to rebase |
28a58be
to
4df2fa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a useful module to enable.
Some formatting nits:
- please consider renaming to
rtkSrc
to match the other fixed-output derivations in this expression - please move to above
swigUnstable
next to the other fixed-output derivations and add an extra linebreak (unfortunatelynixfmt
doesn't deal with this)
4df2fa5
to
d90c9b9
Compare
d90c9b9
to
ad6f3fb
Compare
Should be good now @bcdarwin! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Hey @bcdarwin what else needs to be done to merge this? (I'm fine with waiting, but it's been a while since I contributed so I don't know if I need to get someone else or if it's in a pipeline somewhere to get merged) |
Nothing, someone with the commit bit just needs to see and merge it. (But also see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#practical-contributing-advice.) |
Things done
ITK has a bunch of remote modules that can be used. This one enables RTK, which includes ct reconstruction. I haven't attempted adding more of them yet because this is the only one I need at the moment, but if I have time, they could be added. It might be better to get this merged first though.
As far as I can tell, building this module separately from itk is possible, but installing it is not supported: 3
https://github.com/RTKConsortium/RTK/blob/master/INSTALLATION.md
I have built it but haven't tested it yet(I am about to do so though).
Pinging @bcdarwin as a maintainer of this package.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.