Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

morewaita-icon-theme: 45 -> 47.1 #353026

Merged
merged 1 commit into from
Nov 3, 2024
Merged

morewaita-icon-theme: 45 -> 47.1 #353026

merged 1 commit into from
Nov 3, 2024

Conversation

Cameo007
Copy link
Contributor

@Cameo007 Cameo007 commented Nov 1, 2024

This PR aims to update the MoreWaita icon theme to v47.1 from v45.
This also includes v46, v47

I am new to nixpkgs, so please tell me if I missed something.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 1, 2024
@ofborg ofborg bot requested a review from pkosel November 2, 2024 11:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 2, 2024
surfaceflinger
surfaceflinger approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@surfaceflinger surfaceflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2077

@jopejoe1 jopejoe1 merged commit d2b6995 into NixOS:master Nov 3, 2024
32 of 33 checks passed
@Cameo007 Cameo007 deleted the update-morewaita-icon-theme branch November 3, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surfaceflinger surfaceflinger surfaceflinger approved these changes

@jopejoe1 jopejoe1 jopejoe1 approved these changes

@pkosel pkosel Awaiting requested review from pkosel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Cameo007 @nixos-discourse @jopejoe1 @surfaceflinger @wegank @NixOSInfra