Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portmod: 2.6.2 -> 2.8.0 #353324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

marius851000
Copy link
Contributor

@marius851000 marius851000 commented Nov 3, 2024

Things done

Updated to 2.8.0, and adapted change for the fact it now fetch some binaries (and their deps) from it’s own repo.

portmod-gui doesn’t work (but presumably didn’t previously too). This might be the subject of another PR.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

I see there is another already opened PR regarding this: #353046
only tried with openmw. I’ll update this PR with some idea from there. And make it run on my hydra. And update my hydra for portmod package CI ( at https://hydra.mariusdavid.fr/jobset/portmod/openmw-mods )


Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@zimward zimward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also move this package to by-name

pkgs/games/portmod/default.nix Outdated Show resolved Hide resolved
@zimward zimward added the 8.has: package (update) This PR updates a package to a newer version label Nov 4, 2024
@marius851000
Copy link
Contributor Author

@zimward regardig moving it to treewide, wasn’t it supposed to be an automated process? Or has the green light been given for manually moving it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants