python312Packages.terminaltables3: init at 4.0.0

[Kek5chen]

Things done

terminaltables3 package as discussed in #353771.

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[FliegendeWurst]

Also add yourself to maintainer-list.nix :)

[Kek5chen]

Already done. I'm still waiting for #353536

[Kek5chen]

I extracted it into #354251

[natsukium]

This package is a python library, so please change your commit message to python312Packages.terminaltables3: init at 4.0.0.

Commit names of Python libraries should reflect that they are Python libraries, so write for example python311Packages.numpy: 1.11 -> 1.12. It is highly recommended to specify the current default version to enable automatic build by ofborg. Note that pythonPackages is an alias for python27Packages.

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#contributing-guidelines-contributing-guidelines

[NetaliDev]

Uhhhm, there are tests: https://github.com/matthewdeanmartin/terminaltables3/tree/master/tests

It can be that the tests aren't included on PyPi. But they should be when you change src to the GitHub-Repo.

[Kek5chen]

good idea, i'm gonna do that then.

[Kek5chen]

I don't think the fork cares about the tests

============================= test session starts ==============================
platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0
rootdir: /build/source
configfile: pyproject.toml
collected 801 items                                                            

tests/test_all_tables_e2e/test_ascii_table.py ..s                        [  0%]
tests/test_all_tables_e2e/test_double_table.py ..s                       [  0%]
tests/test_all_tables_e2e/test_github_table.py ..                        [  0%]
tests/test_all_tables_e2e/test_porcelain_table.py ..                     [  1%]
tests/test_all_tables_e2e/test_single_table.py ..                        [  1%]
tests/test_all_tables_e2e/test_single_table_windows.py sss               [  1%]
tests/test_ascii_table.py ......................                         [  4%]
tests/test_base_table/test_gen_row_lines.py ...............              [  6%]
tests/test_base_table/test_gen_table.py ....................             [  8%]
tests/test_base_table/test_horizontal_border.py ................         [ 10%]
tests/test_base_table/test_table.py .......F                             [ 11%]
tests/test_build/test_build_border.py .................................. [ 16%]
........................................................................ [ 25%]
........................................................................ [ 34%]
........................................................................ [ 43%]
........................................................................ [ 52%]
........................................................................ [ 61%]
...................................FFFFFFFFFFFFFFFFFF.FFFFFFFFFFFFFF.FFF [ 70%]
FFFFFFFFFFFFFFF.FFFFFFFFFFFFFF.....                                      [ 74%]
tests/test_build/test_build_row.py ......                                [ 75%]
tests/test_build/test_combine.py ......                                  [ 76%]
tests/test_build/test_flatten.py ..                                      [ 76%]
tests/test_examples.py ...                                               [ 76%]
tests/test_terminal_io/test_get_console_info.py .                        [ 76%]
tests/test_terminal_io/test_set_terminal_title.py sssssssss              [ 77%]
tests/test_terminal_io/test_terminal_size.py .....                       [ 78%]
tests/test_width_and_alignment/test_align_and_pad_cell.py ........F..... [ 80%]
......F...........F...........F...........F......F......F......F......F. [ 89%]
.....F................................F                                  [ 94%]
tests/test_width_and_alignment/test_column_max_width.py ...              [ 94%]
tests/test_width_and_alignment/test_max_dimensions.py ...........        [ 95%]
tests/test_width_and_alignment/test_table_width.py ...                   [ 96%]
tests/test_width_and_alignment/test_visible_width.py ................... [ 98%]
...........                                                              [100%]

=================================== FAILURES ===================================
__________________________________ test_color __________________________________

[Kek5chen]

A sample:

        if left and right:
            expected = left + expected + right
        actual = build_border(outer_widths, "-", left, intersect, right, title=title)
>       assert "".join(actual) == expected
E       AssertionError: assert 'TEST--------' == '\x1b[34mTEST\x1b[0m--------'
E         
E         - TEST--------
E         + TEST--------

[NetaliDev]

Very weird. I can replicate the failing tests. But I wonder why nearly every test got touched in the 4.0.0 commit matthewdeanmartin/terminaltables3@f1c465b

[Kek5chen]

looks like an autoformatting commit