Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immich: 1.119.1 -> 1.120.1 #354083

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

immich: 1.119.1 -> 1.120.1 #354083

wants to merge 2 commits into from

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Nov 6, 2024

Changelog:
https://github.com/immich-app/immich/releases/tag/v1.120.0
https://github.com/immich-app/immich/releases/tag/v1.120.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex
Copy link
Member

Scrumplex commented Nov 6, 2024

immich-app/immich#13773 added a regular database dump/backup job that utilizes pg_dumpall and gzip. I assume we need to add these to PATH using our existing wrapper.

@dotlambda
Copy link
Member Author

Is there a way to start the backup manually so we can run it in the test?

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 6, 2024
@Scrumplex
Copy link
Member

Is there a way to start the backup manually so we can run it in the test?

I think we should be able to trigger it using the following curl:

$ curl -X PUT --json '{"command": "start"}' "$baseUrl/api/jobs/backupDatabase"

And check for completion

$ curl "$baseUrl/api/jobs" | jq '.backupDatabase.jobCounts.completed > 0'

@teto
Copy link
Member

teto commented Nov 6, 2024

dope ! I thought of suggesting a nixos module to backup immich this week (on the discussed nextcloud model) but this is too specific to be reusable properly. It was simpler to use the restic and postgresqlBackup module already. I might have to disable the latter if immich already does it !

@dotlambda
Copy link
Member Author

Sounds like we're not supposed to use the built-in database backups: immich-app/immich#13971 (comment)

@@ -116,7 +116,7 @@ in
description = ''
Configuration for Immich.
See <https://immich.app/docs/install/config-file/> or navigate to
<https://your-immich-domain/admin/system-settings> for
<https://my.immich.app/admin/system-settings> for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change? should we be linking to their site? I think the placeholder is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole purpose of https://my.immich.app/ is to redirect to your Immich instance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 🤷

@ofborg ofborg bot requested a review from Titaniumtown November 7, 2024 06:20
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Nov 7, 2024
@dotlambda dotlambda marked this pull request as ready for review November 7, 2024 15:31
@dotlambda dotlambda changed the title immich: 1.119.1 -> 1.120.0 immich: 1.119.1 -> 1.120.1 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants