Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubetrim: init at 0.0.1 #354130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Nov 7, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bbigras bbigras marked this pull request as ready for review November 7, 2024 03:27
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have a --version command we could take advantage of with a versionCheckHook?

pkgs/by-name/ku/kubetrim/package.nix Outdated Show resolved Hide resolved
@bbigras
Copy link
Contributor Author

bbigras commented Nov 7, 2024

Does this have a --version command we could take advantage of with a versionCheckHook?

No but I made an issue for it. alexellis/kubetrim#10

@khaneliman
Copy link
Contributor

LGTM, could you squash the commits, please.

Co-authored-by: Austin Horstman <[email protected]>
@bbigras
Copy link
Contributor Author

bbigras commented Nov 7, 2024

LGTM, could you squash the commits, please.

Done.

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354130


x86_64-linux

✅ 1 package built:
  • kubetrim

aarch64-linux

✅ 1 package built:
  • kubetrim

x86_64-darwin

✅ 1 package built:
  • kubetrim

aarch64-darwin

✅ 1 package built:
  • kubetrim

@khaneliman khaneliman added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants