Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-completion: modernize, add update script #354145

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tomodachi94
Copy link
Member

@tomodachi94 tomodachi94 commented Nov 7, 2024

  • Format with nixfmt-rfc-style
  • Move to by-name
  • Use various best practices
  • Add update script

This is preparation for the proposed Java team adopting the package in #352938.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

* use `installShellFiles` to avoid
  reinventing the wheel
* use stdenvNoCC.mkDerivation
  to avoid pulling in a compiler
* use `finalAttrs`
* remove `with lib;` in `meta`
@tomodachi94 tomodachi94 force-pushed the enhance/gradle-completion/modernize branch from 88e7524 to d7d9a83 Compare November 7, 2024 18:09
@github-actions github-actions bot removed the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 7, 2024
@tomodachi94 tomodachi94 force-pushed the enhance/gradle-completion/modernize branch from d7d9a83 to 0a2f0a4 Compare November 7, 2024 18:12
@tomodachi94 tomodachi94 added the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 7, 2024
@github-actions github-actions bot removed the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 7, 2024
@tomodachi94 tomodachi94 added the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants