Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marktext: build from source #354253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Nov 7, 2024

After a lot of dirty work. It finally start on the newest electron.

image

The newest dev version can run on the newest nodejs which 0.17.1 can't becuase of keyboard-layout.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 changed the title marktext: build from source. marktext: build from source Nov 7, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 7, 2024
@ofborg ofborg bot requested review from eduarrrd and nh2 November 7, 2024 17:47
@Bot-wxt1221 Bot-wxt1221 force-pushed the marktext branch 2 times, most recently from f5842f3 to 1a842eb Compare November 8, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant