python{27,39,310,311,312,313,314}: use a bootstrap SDK on Darwin #354278
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this is necessary now, since it should already be handled as part of the bootstrap. This might not be the right fix but it does fix eval.
|
Fixed more properly by #354286. |
|
Nope, turns out we need this one too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this is necessary now, since it should already be handled as part of the bootstrap. This might not be the right fix but it does fix eval.
cc @NixOS/darwin-core since Randy might have to clean up my mess after.
This also only affected explicitly‐versioned SDKs, as
apple-sdk.stdenvandapple-sdk_10_12.stdenvare different bootstrap stages; I’m not sure if that’s intentional or not.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.