Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cartridges: 2.9.3 -> 2.10.1 #354306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cartridges: 2.9.3 -> 2.10.1 #354306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f23ed
cartridges: 2.9.3 -> 2.10.1
getchoo Nov 7, 2024
a01b23f
cartridges: run meson checks
getchoo Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions pkgs/by-name/ca/cartridges/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,41 @@
{
lib,
fetchFromGitHub,
python3Packages,
appstream,
blueprint-compiler,
desktop-file-utils,
gobject-introspection,
fetchFromGitHub,
glib,
glib-networking,
gobject-introspection,
gtk4,
libadwaita,
meson,
ninja,
pkg-config,
python3Packages,
wrapGAppsHook4,
}:

python3Packages.buildPythonApplication rec {
pname = "cartridges";
version = "2.9.3";
version = "2.10.1";
pyproject = false;

src = fetchFromGitHub {
owner = "kra-mo";
repo = "cartridges";
rev = "refs/tags/v${version}";
hash = "sha256-37i8p6KaS/G7ybw850XYaPiG83/Lffn/+21xVk5xva0=";
hash = "sha256-uwU0jW5+33hiqpuG83r0GVfANl6ltDLa3s4s0IJHRoQ=";
};

strictDeps = true;

nativeBuildInputs = [
appstream
blueprint-compiler
desktop-file-utils
desktop-file-utils # for `desktop-file-validate`
glib # for `glib-compile-schemas`
gtk4 # for `gtk-update-icon-cache`
gobject-introspection
meson
ninja
Expand All @@ -49,12 +56,19 @@ python3Packages.buildPythonApplication rec {
];

dontWrapGApps = true;
makeWrapperArgs = [ ''''${gappsWrapperArgs[@]}'' ];
makeWrapperArgs = [ "\${gappsWrapperArgs[@]}" ];

postFixup = ''
wrapPythonProgramsIn $out/libexec $out $pythonPath
'';

# NOTE: `postCheck` is intentionally not used here, as the entire checkPhase
# is skipped by `buildPythonApplication`
# https://github.com/NixOS/nixpkgs/blob/9d4343b7b27a3e6f08fc22ead568233ff24bbbde/pkgs/development/interpreters/python/mk-python-derivation.nix#L296
postInstallCheck = ''
mesonCheckPhase
'';

meta = {
description = "GTK4 + Libadwaita game launcher";
longDescription = ''
Expand All @@ -64,7 +78,7 @@ python3Packages.buildPythonApplication rec {
You can sort and hide games or download cover art from SteamGridDB.
'';
homepage = "https://apps.gnome.org/Cartridges/";
changelog = "https://github.com/kra-mo/cartridges/releases/tag/${lib.removePrefix "refs/tags/" src.rev}";
changelog = "https://github.com/kra-mo/cartridges/releases/tag/${version}";
license = lib.licenses.gpl3Plus;
maintainers = with lib.maintainers; [ getchoo ];
mainProgram = "cartridges";
Expand Down