Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim, neovim: format with nixfmt-rfc-style #359401

Closed
wants to merge 1 commit into from

Conversation

PerchunPak
Copy link
Member

@PerchunPak PerchunPak commented Nov 26, 2024

Reformatted these paths (found with fd vim):

  • nixos/modules/programs/neovim.nix
  • nixos/modules/programs/vim.nix
  • pkgs/applications/editors/neovim/
  • pkgs/applications/editors/vim/
  • pkgs/by-name/ne/neovim-unwrapped/
  • pkgs/test/vim/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PerchunPak
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • vimPluginsUpdater

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim labels Nov 26, 2024
Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformats need to add the commit to .git-blame-ignore-revs

@teto
Copy link
Member

teto commented Nov 26, 2024

I see this as noise. Unless it's enforced by CI, it will diverge again and we'll have to reformat pending PRs. I would prefer to wait for nixpkgs level initiative for this but if the (neo)vim team is excited for this, we can do it.

EDIT: by "wait", I believe formatting standardization will reach nixpkgs maybe this year.

@PerchunPak
Copy link
Member Author

PerchunPak commented Nov 26, 2024

EDIT: by "wait", I believe formatting standardization will reach nixpkgs maybe this year.

Oh, you are right! Holding this back

NixOS/nixfmt#257 (review)
https://discourse.nixos.org/t/formatting-team-meeting-2024-11-26/56643

@PerchunPak PerchunPak closed this Nov 26, 2024
@PerchunPak PerchunPak deleted the neovim-format branch November 26, 2024 22:11
@PerchunPak PerchunPak mentioned this pull request Dec 2, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: vim 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants