Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerd-fonts: correct typos in descriptions #361818

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

Ben9986
Copy link
Contributor

@Ben9986 Ben9986 commented Dec 4, 2024

Characters such as & and ' were encoded as & and \u2019. This fixes that.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ben9986 Ben9986 added the 8.has: documentation This PR adds or changes documentation label Dec 4, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 4, 2024
@misuzu
Copy link
Contributor

misuzu commented Dec 4, 2024

To properly fix the issue it's required to fix the update script or your changes will be overwritten by the next run of this script.

@Ben9986
Copy link
Contributor Author

Ben9986 commented Dec 6, 2024

To properly fix the issue it's required to fix the update script or your changes will be overwritten by the next run of this script.

ah missed that thanks, will have a look

@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Dec 6, 2024
@Ben9986
Copy link
Contributor Author

Ben9986 commented Dec 7, 2024

So I've fixed the issue with apostrophes but I'm not good enough with python to fix the ampersand issue. Perhaps @rc-zb could attempt? I assume it would be trivial if I actually knew python 👀

@rc-zb
Copy link
Contributor

rc-zb commented Dec 7, 2024

No, I seldom write in Python and know little about it.

From search engine and LLM I heard html.unescape, and it seems to work.

@misuzu
Copy link
Contributor

misuzu commented Dec 7, 2024

Try this:

def slicedict(d, ks):
    return {k: html.unescape(d[k]) for k in ks}

Make sure to import html

@Ben9986
Copy link
Contributor Author

Ben9986 commented Dec 7, 2024

Try this:

def slicedict(d, ks):
    return {k: html.unescape(d[k]) for k in ks}

Make sure to import html

That's sorted it, thanks.

Ready for merge imo

@misuzu misuzu merged commit b7073fc into NixOS:master Dec 7, 2024
19 of 20 checks passed
@Ben9986 Ben9986 deleted the patch-1 branch December 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants