Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onedrive: patch to fix openssl error #362601

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

Ben9986
Copy link
Contributor

@Ben9986 Ben9986 commented Dec 6, 2024

This adds a temporary patch direct from upstream which will be included in the next package version. The patch fixes an openssl version check error that prevents the program from running. See upstream PR here and discourse issue here. It's not clear when the next version will be released so this gets the package working in the meantime.

This patch should be removed when v2.5.4 is released, hence a comment has been added.

If this isn't the preferred way of doing this please let me know.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 6, 2024
pkgs/by-name/on/onedrive/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/on/onedrive/package.nix Outdated Show resolved Hide resolved
@Aleksanaa
Copy link
Member

@ofborg build onedrive

@Aleksanaa Aleksanaa added the backport release-24.11 Backport PR automatically label Dec 7, 2024
@Aleksanaa Aleksanaa merged commit bc33cb6 into NixOS:master Dec 7, 2024
23 of 25 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 7, 2024

Successfully created backport PR for release-24.11:

@Ben9986 Ben9986 deleted the onedrive-patch branch December 7, 2024 17:00
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/onedrive-unable-to-parse-openssl-version/56877/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants