Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsocks: fix build with GCC 14 #369474

Merged
merged 1 commit into from
Jan 11, 2025
Merged

tsocks: fix build with GCC 14 #369474

merged 1 commit into from
Jan 11, 2025

Conversation

nmouha
Copy link
Contributor

@nmouha nmouha commented Dec 30, 2024

The tsocks package no longer compiles due to a bug in ./configure:

configure:774:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  774 | main(){return(0);}

Replacing main() by int main() fixes the bug and allows the package to compile.

ref. #356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Dec 31, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369474


x86_64-linux

✅ 1 package built:
  • tsocks

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 1, 2025
@FliegendeWurst FliegendeWurst changed the title tsocks: fix ./configure error tsocks: fix build with GCC 14 Jan 11, 2025
@FliegendeWurst FliegendeWurst merged commit 2947357 into NixOS:master Jan 11, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants