Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiramisu: 2.0-unstable-2023-03-29 -> 2.0.20240610 #371038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wishfort36
Copy link
Contributor

This change essentially doesn't do anything (note that the hash is unchanged). There are no new commits from the project, so we're only changing the version number to the release version, telling the user that the version is stable and from a release, and to tell Repology and other trackers that we are indeed on the newest version of this package. I've also cleaned the code slightly.

Things done

  • Built on platform(s)
    • x86_64-linux (NixOS)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 5, 2025
@nix-owners nix-owners bot requested a review from moni-dz January 5, 2025 02:09
@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371038


x86_64-linux

✅ 1 package built:
  • tiramisu

@wishfort36
Copy link
Contributor Author

Hm; it seems that conventions have changed the past few years. i've done the requested changes.

@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371038


x86_64-linux

✅ 1 package built:
  • tiramisu

@wishfort36
Copy link
Contributor Author

Done. While best practices are nice, I must say that this seems like an awful lot of nitpicking for a change that's supposed to do nothing.

pkgs/by-name/ti/tiramisu/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ti/tiramisu/package.nix Outdated Show resolved Hide resolved
@wishfort36
Copy link
Contributor Author

Done.

@eljamm
Copy link
Contributor

eljamm commented Jan 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371038


x86_64-linux

✅ 1 package built:
  • tiramisu

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants