-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiramisu: 2.0-unstable-2023-03-29 -> 2.0.20240610 #371038
base: master
Are you sure you want to change the base?
Conversation
|
Hm; it seems that conventions have changed the past few years. i've done the requested changes. |
|
Done. While best practices are nice, I must say that this seems like an awful lot of nitpicking for a change that's supposed to do nothing. |
Done. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This change essentially doesn't do anything (note that the hash is unchanged). There are no new commits from the project, so we're only changing the version number to the release version, telling the user that the version is stable and from a release, and to tell Repology and other trackers that we are indeed on the newest version of this package. I've also cleaned the code slightly.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.