-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.beancount3: init at 3.0.0 #371541
base: master
Are you sure you want to change the base?
Conversation
I am not using v3 currently. How is it working with existing tools now? |
I used v3 for the last 6 months, and it works ok for me. However, I don't use any custom importers based on Overall, I think it is in good enough shape for everyday use, but it depends on your setup. |
It would be nice to have v3 in nixpkgs. But since there are major incompatibilities between v2 and v3, and v2 is still widely used, I would like to keep both v2 and v3 in nixpkgs, i.e. |
Ok, makes sense. I reworked PR: added separate package for beancount3 and support for building fava with either version. This way user can specify |
fetchPypi, | ||
python3Packages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very cumbersome to override python3Packages to build fava with beancount3 due to the strange design in python3Packages. Can we just build fava with beancount3? May this cause compatibility issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it help if, instead of accepting python3Packages, the package accepted beancount dependency directly? I think this wouldn't work since package uses buildPythonApplication
It is possible to build Fava either with v2 or v3, but as far as I understand depending on version used Fava uses different approach for importers under the hood
https://github.com/beancount/fava/blob/main/CHANGES
For importers, this sticks to beancount.ingest on v2 and used beangulp for v3.
Due to changes related to duplicate detection, duplicate detection is not
automatically done by Fava here but can still be manually specified as hooks.
Also, I'm not sure if it is a good idea to mix-match beancount version between different packages (fava, beanprice, beanquery, beangulp, etc.).
Added package for
beancount3
Update
fava
to version 1.30 which supports bothbeancount2
andbeancount3
.Add package for
beangulp
as a replacement forbeancount.ingest
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.