Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs_23: 23.5.0 -> 23.6.0 #371909

Merged
merged 1 commit into from
Jan 21, 2025
Merged

nodejs_23: 23.5.0 -> 23.6.0 #371909

merged 1 commit into from
Jan 21, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 7, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aduh95 aduh95 added the backport release-24.11 Backport PR automatically label Jan 18, 2025
@Conni2461
Copy link
Member

cant this target master as it only rebuilds like 14packages for linux? no need to target staging

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 19, 2025

Now that #371501 has landed, I guess I can

@aduh95 aduh95 force-pushed the nodejs-23 branch 2 times, most recently from a374103 to a6b7457 Compare January 19, 2025 10:11
@aduh95 aduh95 changed the base branch from staging to master January 19, 2025 10:11
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 20, 2025
@0x4A6F 0x4A6F merged commit f7b9530 into NixOS:master Jan 21, 2025
26 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 21, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 21, 2025
Merged
1 task
@aduh95 aduh95 deleted the nodejs-23 branch January 21, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @Conni2461 @0x4A6F @wegank