Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 24.11] More string fixes #372975

Open
wants to merge 2 commits into
base: release-24.11
Choose a base branch
from
Open

[Backport 24.11] More string fixes #372975

wants to merge 2 commits into from
+113 −88

Conversation

piegamesde
Copy link
Member

Backport of #367757

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware 6.topic: lib The Nixpkgs function library 6.topic: nvidia labels Jan 11, 2025
@piegamesde piegamesde requested a review from pbsds January 11, 2025 16:31
@nix-owners nix-owners bot requested review from Profpatsch and infinisil January 11, 2025 16:32
@piegamesde piegamesde mentioned this pull request Jan 11, 2025
Merged
13 tasks
@nix-owners nix-owners bot requested a review from avdv January 11, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbsds pbsds Awaiting requested review from pbsds

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@infinisil infinisil Awaiting requested review from infinisil

@avdv avdv Awaiting requested review from avdv

Assignees
No one assigned
Labels
6.topic: hardware 6.topic: lib The Nixpkgs function library 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nvidia 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@piegamesde