Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: fix datalad issue #372997

Open
wants to merge 1 commit into
base: release-24.11
Choose a base branch
from

Conversation

malikwirin
Copy link

@malikwirin malikwirin commented Jan 11, 2025

The current version of datalad 1.1.3 no longer builds because of failing tests:

error: builder for '/nix/store/s42j2jkalg76wvx1dakmwpjc2r2fzrbc-python3.12-datalad-1.1.3.drv' failed with exit code 1;
       last 25 log lines:
       >
       > datalad/downloaders/tests/test_http.py: 13 warnings
       >   /nix/store/la3cafkb1w1s9b4jbr5g61b98gcw8x9h-python3.12-httpretty-1.1.4/lib/python3.12/site-packages/httpretty/core.py:1077: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
       >     now = datetime.utcnow()
       >
       > datalad/downloaders/tests/test_http.py: 1 warning
       > datalad/downloaders/tests/test_shub.py: 3 warnings
       > datalad/local/tests/test_addurls.py: 1 warning
       > datalad/local/tests/test_copy_file.py: 1 warning
       > datalad/local/tests/test_download_url.py: 2 warnings
       > datalad/runner/tests/test_nonasyncrunner.py: 1 warning
       > datalad/support/tests/test_annexrepo.py: 6 warnings
       > datalad/support/tests/test_locking.py: 2 warnings
       > datalad/tests/test_tests_utils_pytest.py: 1 warning
       >   /nix/store/kjgslpdqchx1sm7a5h9xibi5rrqcqfnl-python3-3.12.8/lib/python3.12/multiprocessing/popen_fork.py:66: DeprecationWarning: This process (pid=1441) is multi-threaded, use of fork() may lead to deadlocks in the child.
       >     self.pid = os.fork()
       >
       > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
       > =========================== short test summary info ============================
       > FAILED datalad/cli/tests/test_main.py::test_version - assert 2 == 0
       > FAILED datalad/cli/tests/test_main.py::test_help_np - assert 2 == 0
       > FAILED datalad/cli/tests/test_main.py::test_dashh - assert 2 == 0
       > FAILED datalad/cli/tests/test_main.py::test_combined_short_option - AssertionError: assert 'too few arguments' in 'usage: datalad [-c (:name|na...
       > FAILED datalad/cli/tests/test_parser.py::test_setup - Failed: DID NOT RAISE <class 'SystemExit'>
       > = 5 failed, 933 passed, 63 skipped, 280 deselected, 2 xfailed, 1 xpassed, 160 warnings in 1572.79s (0:26:12) =
       For full logs, run 'nix log /nix/store/s42j2jkalg76wvx1dakmwpjc2r2fzrbc-python3.12-datalad-1.1.3.drv'.

using the version from the master branch fixes the issue.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants