-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libgit2: 1.8.4 -> 1.9.0 (also pygit2 update) #373096
base: staging
Are you sure you want to change the base?
Conversation
nixpkgs-review is still running... there are 11 failures so far, most of which are projects that have libgit2 pinned to |
libgit2 seems to have introduced breaking changes this version, so this is gonna be a nasty upgrade... |
FINALLY --------- Report for 'x86_64-linux' --------- 1 package blacklisted: 153 packages failed to build: 255 packages built: |
b100c6a
to
59b65ce
Compare
59b65ce
to
9cd3837
Compare
Pushed to:
Will try another review with these fixes; hopefully it’ll be considerably more green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nix side looks good to me.
9cd3837
to
6973ffc
Compare
6973ffc
to
3b02ae0
Compare
This comment has been minimized.
This comment has been minimized.
3b02ae0
to
e853853
Compare
We were already patching
Nothing else really looks concerning, assuming that the |
--------- Report for 'x86_64-linux' --------- 1 package blacklisted: 37 packages failed to build: 371 packages built: |
The actual regressions vs.
I’ll try to take a look at these tonight. |
edo9300/edopro#284 legitimate failure from upstream with no patch available for |
|
also poac, which was renamed to cabinpkg on master, should be fixed with #376011 |
Also includes a small configuration diff to get it to build on OpenBSD. I'll run nixpkgs-review overnight.
Changelog
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.