Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs_2_3: init at 2.3.0 #373599

Merged
merged 2 commits into from
Jan 14, 2025
Merged

zfs_2_3: init at 2.3.0 #373599

merged 2 commits into from
Jan 14, 2025

Conversation

amarshall
Copy link
Member

@amarshall amarshall commented Jan 14, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 14, 2025
@amarshall
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4_hardened.zfs_2_3
  • linuxKernel.packages.linux_5_4_hardened.zfs_unstable
✅ 21 packages built:
  • linuxKernel.packages.linux_5_10.zfs_2_3 (linuxKernel.packages.linux_5_10.zfs_unstable)
  • linuxKernel.packages.linux_5_10_hardened.zfs_2_3 (linuxKernel.packages.linux_5_10_hardened.zfs_unstable)
  • linuxKernel.packages.linux_5_15.zfs_2_3 (linuxKernel.packages.linux_5_15.zfs_unstable)
  • linuxKernel.packages.linux_5_15_hardened.zfs_2_3 (linuxKernel.packages.linux_5_15_hardened.zfs_unstable)
  • linuxKernel.packages.linux_5_4.zfs_2_3 (linuxKernel.packages.linux_5_4.zfs_unstable)
  • linuxKernel.packages.linux_6_1.zfs_2_3 (linuxKernel.packages.linux_6_1.zfs_unstable)
  • linuxKernel.packages.linux_6_11.zfs_2_3 (linuxKernel.packages.linux_6_11.zfs_unstable)
  • linuxKernel.packages.linux_6_11_hardened.zfs_2_3 (linuxKernel.packages.linux_6_11_hardened.zfs_unstable)
  • linuxKernel.packages.linux_6_12.zfs_2_3 (linuxKernel.packages.linux_6_12.zfs_unstable)
  • linuxKernel.packages.linux_6_12_hardened.zfs_2_3 (linuxKernel.packages.linux_6_12_hardened.zfs_unstable)
  • linuxKernel.packages.linux_6_1_hardened.zfs_2_3 (linuxKernel.packages.linux_6_1_hardened.zfs_unstable)
  • linuxKernel.packages.linux_6_6.zfs_2_3 (linuxKernel.packages.linux_6_6.zfs_unstable)
  • linuxKernel.packages.linux_hardened.zfs_2_3 (linuxKernel.packages.linux_6_6_hardened.zfs_2_3 ,linuxKernel.packages.linux_hardened.zfs_unstable)
  • linuxKernel.packages.linux_latest_libre.zfs_2_3 (linuxKernel.packages.linux_latest_libre.zfs_unstable)
  • linuxKernel.packages.linux_libre.zfs_2_3 (linuxKernel.packages.linux_libre.zfs_unstable)
  • linuxKernel.packages.linux_lqx.zfs_2_3 (linuxKernel.packages.linux_lqx.zfs_unstable)
  • linuxKernel.packages.linux_xanmod.zfs_2_3 (linuxKernel.packages.linux_xanmod.zfs_unstable)
  • linuxKernel.packages.linux_xanmod_latest.zfs_2_3 (linuxKernel.packages.linux_xanmod_latest.zfs_unstable ,linuxKernel.packages.linux_xanmod_stable.zfs_2_3 ,linuxKernel.packages.linux_xanmod_stable.zfs_unstable)
  • linuxKernel.packages.linux_zen.zfs_2_3 (linuxKernel.packages.linux_zen.zfs_unstable)
  • zfs_2_3 (zfs_unstable)
  • zfs_2_3.dev (zfs_unstable.dev)

@amarshall amarshall marked this pull request as ready for review January 14, 2025 02:11
@nix-owners nix-owners bot requested a review from RaitoBezarius January 14, 2025 02:13
@adamcstephens adamcstephens merged commit c44bf8b into NixOS:master Jan 14, 2025
52 of 55 checks passed
@adamcstephens
Copy link
Contributor

I don't think we should change the 24.11 default version. We should change the unstable default to 2.3, but maybe after some people have run this on their systems?

@amarshall amarshall added the backport release-24.11 Backport PR automatically label Jan 14, 2025
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 14, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-373599-to-release-24.11 origin/release-24.11
cd .worktree/backport-373599-to-release-24.11
git switch --create backport-373599-to-release-24.11
git cherry-pick -x 40e0f7233b33aabebc42167a5e16d386a45972c9 6477277a79d19ac852b79d000bb6ce02c6f4adbb

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2025

I don't think we should change the 24.11 default version. We should change the unstable default to 2.3, but maybe after some people have run this on their systems?

This is not changing any default.

@adamcstephens
Copy link
Contributor

This is not changing any default.

I'm aware, but amarshall asked for input in the original description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants