Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkPackageOption: add defaultText option #375424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mkPackageOption: add defaultText option #375424

wants to merge 1 commit into from

Conversation

Pandapip1
Copy link
Contributor

Separated from #374656

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: module system About "NixOS" module system internals 6.topic: lib The Nixpkgs function library labels Jan 21, 2025
@nix-owners nix-owners bot requested review from roberth and infinisil January 21, 2025 02:15
roberth
roberth reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks alright, but the test doesn't work.

lib/tests/modules/declare-mkPackageOption.nix Show resolved Hide resolved
lib/options.nix Outdated Show resolved Hide resolved
@Pandapip1 Pandapip1 force-pushed the mkpackageoption-defaulttext branch 2 times, most recently from 54f3b56 to b761645 Compare January 28, 2025 22:05
@Pandapip1 Pandapip1 force-pushed the mkpackageoption-defaulttext branch from b761645 to 27f79a9 Compare January 28, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: lib The Nixpkgs function library 6.topic: module system About "NixOS" module system internals 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pandapip1 @roberth