Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mupdf: 1.25.2 -> 1.25.3 #376020

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

mupdf: 1.25.2 -> 1.25.3 #376020

wants to merge 2 commits into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 23, 2025

Changes: https://mupdf.com/releases/history

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
Copy link
Contributor Author

trofi commented Jan 23, 2025

pymupdf tests are sad. Converting to draft:

python3.12-pymupdf> FAILED tests/test_pagedelete.py::test_deletion - TypeError: pdf_rearrange_pages2() missing 1 required positional argument: '...
python3.12-pymupdf> FAILED tests/test_pagedelete.py::test_3150 - TypeError: pdf_rearrange_pages2() missing 1 required positional argument: '...
python3.12-pymupdf> FAILED tests/test_textextract.py::test_3705 - TypeError: pdf_rearrange_pages2() missing 1 required positional argument: '...

@trofi trofi marked this pull request as ready for review January 23, 2025 06:46
@trofi
Copy link
Contributor Author

trofi commented Jan 23, 2025

Fixed by backporting pymupdf fix. Ready for review.

@nix-owners nix-owners bot requested a review from teto January 23, 2025 06:53
@teto teto removed their request for review January 23, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant