Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mattermost: fix update script attributes #376839

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 26, 2025

Since we now have a wrapper derivation, we need to expose the inner attributes to make the update script happy.

Followup to #208181 which introduced this issue.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Since we now have a wrapper derivation, we need to expose the inner
attributes to make the update script happy.
@numinit numinit requested a review from drupol January 26, 2025 00:58
@drupol drupol merged commit c003f89 into NixOS:master Jan 26, 2025
58 of 60 checks passed
@numinit numinit deleted the mattermost/toplevel-attributes branch January 26, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants