Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] nixos/profiles/hardened: add disable option #379181

Closed
wants to merge 1 commit into from

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Feb 3, 2025

Bot-based backport to release-24.11, triggered by a label in #375114.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 3, 2025
@felbinger
Copy link
Member

Requires #380985 to get picked up by module system... I oversaw this before

@SuperSandro2000
Copy link
Member

I cherry-picked this from the PR into here.

@SuperSandro2000
Copy link
Member

@felbinger that was not the smartest idea to add the module to the module list if we still have the enable option that defaults to true....

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Feb 19, 2025
@felbinger
Copy link
Member

@felbinger that was not the smartest idea to add the module to the module list if we still have the enable option that defaults to true....

Yea, now I see the problem. Sorry...

@felbinger felbinger closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants