Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi-network-manager: init at 2024-09-03 #379331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rofi-network-manager: init at 2024-09-03 #379331

wants to merge 2 commits into from

Conversation

wenjinnn
Copy link

@wenjinnn wenjinnn commented Feb 4, 2025

Add rofi-network-manager, it allow you manage wifi and ethernet with rofi. Provide x11 and wayland version.
Also add wenjinnn to maintainers/maintainer-list.nix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 4, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5177

@wenjinnn wenjinnn force-pushed the wenjinnn/rofi-network-manager branch from d359497 to 8996b55 Compare February 5, 2025 10:56
@wenjinnn wenjinnn force-pushed the wenjinnn/rofi-network-manager branch from 8996b55 to af92a90 Compare February 6, 2025 02:14
@wenjinnn wenjinnn force-pushed the wenjinnn/rofi-network-manager branch from af92a90 to 54304a9 Compare February 6, 2025 02:18
@wenjinnn
Copy link
Author

wenjinnn commented Feb 6, 2025

After checking the source code again I found that sed and awk dependencies are missing, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenjinnn @nixos-discourse @SuperSandro2000