nixos/movim: H2O support, H2O + Ejabberd test, minor fixups #385040
+799
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This 711-line file was expanded into 817-line file by nixfmt. Readability was hurt as now I can’t see as much in my editor at a time; this directly makes editing & reviewing slower as reading is harder. I am upset about this change.
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H2O virtual host support added for easy enabling. Added a test that covers both H2O and Ejabberd (other test is Prosody + Nginx)… which should cover a bigger gamut. As always, fixups were found along the way & documented in separate commits before the big addition.
UNFORTUNATELY,
nixfmthad to be ran which adds a lot of noise to the review & makes the code so much more vertical & therefore harder to read/review. Probably easier to do by commit.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩