Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud31: init at 31.0.0 #385060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

transcaffeine
Copy link
Contributor

Release notes: https://github.com/nextcloud/server/releases/tag/v31.0.0
Upgrade notes: https://docs.nextcloud.com/server/31/admin_manual/release_notes/upgrade_to_31.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 25, 2025
@dotlambda dotlambda requested a review from Ma27 February 25, 2025 18:16
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line latest = 30; in nixos/modules/services/web-apps/nextcloud.nix needs to be updated.

@Ma27
Copy link
Member

Ma27 commented Feb 25, 2025

I'd recommend looking at the old commits adding a new major version for what needs to be done.
New major versions always involve a little fiddling in here since we have no reasonable way to detect N+2 upgrades (nextcloud only allows moving one version forward), so the code is tries to communicate that via warnings which need regular adjustments.

@github-actions github-actions bot added the 8.has: module (update) This PR changes an existing module in `nixos/` label Feb 25, 2025
@transcaffeine
Copy link
Contributor Author

Thanks, after viewing the commit that initialized nextcloud30, i added the nextcloud modules upgrade warnings. I was unsure about the 8.4 PHP update, but it is listed as supported by Nextcloud https://docs.nextcloud.com/server/31/admin_manual/release_notes/upgrade_to_31.html

@@ -868,7 +868,8 @@ in {
++ (optional (versionOlder cfg.package.version "27") (upgradeWarning 26 "23.11"))
++ (optional (versionOlder cfg.package.version "28") (upgradeWarning 27 "24.05"))
++ (optional (versionOlder cfg.package.version "29") (upgradeWarning 28 "24.11"))
++ (optional (versionOlder cfg.package.version "30") (upgradeWarning 29 "24.11"));
++ (optional (versionOlder cfg.package.version "30") (upgradeWarning 29 "24.11"))
++ (optional (versionOlder cfg.package.version "31") (upgradeWarning 30 "25.05"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
++ (optional (versionOlder cfg.package.version "31") (upgradeWarning 30 "25.05"));
++ (optional (versionOlder cfg.package.version "31") (upgradeWarning 30 "25.05"))
;

would make future diffs prettier

);

services.nextcloud.phpPackage =
if versionOlder cfg.package.version "29" then pkgs.php82
else pkgs.php83;
else if versionOlder cfg.package.version "30" then pkgs83
else pkgs.php84;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream still recommends 8.3 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants