-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextcloud31: init at 31.0.0 #385060
base: master
Are you sure you want to change the base?
nextcloud31: init at 31.0.0 #385060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line latest = 30;
in nixos/modules/services/web-apps/nextcloud.nix
needs to be updated.
I'd recommend looking at the old commits adding a new major version for what needs to be done. |
b6a4e00
to
e31967d
Compare
Thanks, after viewing the commit that initialized |
@@ -868,7 +868,8 @@ in { | |||
++ (optional (versionOlder cfg.package.version "27") (upgradeWarning 26 "23.11")) | |||
++ (optional (versionOlder cfg.package.version "28") (upgradeWarning 27 "24.05")) | |||
++ (optional (versionOlder cfg.package.version "29") (upgradeWarning 28 "24.11")) | |||
++ (optional (versionOlder cfg.package.version "30") (upgradeWarning 29 "24.11")); | |||
++ (optional (versionOlder cfg.package.version "30") (upgradeWarning 29 "24.11")) | |||
++ (optional (versionOlder cfg.package.version "31") (upgradeWarning 30 "25.05")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ (optional (versionOlder cfg.package.version "31") (upgradeWarning 30 "25.05")); | |
++ (optional (versionOlder cfg.package.version "31") (upgradeWarning 30 "25.05")) | |
; |
would make future diffs prettier
); | ||
|
||
services.nextcloud.phpPackage = | ||
if versionOlder cfg.package.version "29" then pkgs.php82 | ||
else pkgs.php83; | ||
else if versionOlder cfg.package.version "30" then pkgs83 | ||
else pkgs.php84; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream still recommends 8.3 though.
Release notes: https://github.com/nextcloud/server/releases/tag/v31.0.0
Upgrade notes: https://docs.nextcloud.com/server/31/admin_manual/release_notes/upgrade_to_31.html
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.