Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hooks messages configurable #162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Oct 25, 2023

  1. make hooks messages configurable

    ...and update them to reflect current usage
    
    why:
    - these messages appeared to be just wrong (referencing `aide` instead of firstaide or an `update` command that doesn't appear to exist)
    - and in any case it's nice to have them all customizeable not just the getting_started message. based on the presence of the `Messages` struct I presume this was always intended
    
    how:
    - add fields to `Messages` struct, named based on the hook they are associated with
    - set sensible defaults for messages
    - add messages to the hooks scripts
    - splat configured messages into hooks scripts based on how it was done for the getting_started message
    
    docs: updated the readme to document messages configuration
    
    validation: tested new message configurations in a different project, `cargo test`
    zach-sherman committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    802bb5d View commit details
    Browse the repository at this point in the history
  2. make hooks messages configurable

    ...and update them to reflect current usage
    
    why:
    - these messages appeared to be just wrong (referencing `aide` instead of firstaide or an `update` command that doesn't appear to exist)
    - and in any case it's nice to have them all customizeable not just the getting_started message. based on the presence of the `Messages` struct I presume this was always intended
    
    how:
    - add fields to `Messages` struct, named based on the hook they are associated with
    - set sensible defaults for messages
    - add messages to the hooks scripts
    - splat configured messages into hooks scripts based on how it was done for the getting_started message
    
    docs: updated the readme to document messages configuration
    
    validation: tested new message configurations in a different project, `cargo test`
    zach-sherman committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    cca838c View commit details
    Browse the repository at this point in the history
  3. make hooks messages configurable

    ...and update them to reflect current usage
    
    why:
    - these messages appeared to be just wrong (referencing `aide` instead of firstaide or an `update` command that doesn't appear to exist)
    - and in any case it's nice to have them all customizeable not just the getting_started message. based on the presence of the `Messages` struct I presume this was always intended
    
    how:
    - add fields to `Messages` struct, named based on the hook they are associated with
    - set sensible defaults for messages
    - use serde default attributes to allow mixing defaults and custom messages without errors
    - add messages to the hooks scripts
    - splat configured messages into hooks scripts based on how it was done for the getting_started message
    
    docs: updated the readme to document messages configuration
    
    validation: tested new message configurations in a different project, `cargo test`
    zach-sherman committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ea6116d View commit details
    Browse the repository at this point in the history