nri-kafka: expose retry counts (for worker managing its own offsets) #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only for worker managing its own offsets
omnibs
force-pushed
the
expose-retry-counts
branch
from
6a43312 to
f63a71b
Compare
omnibs
force-pushed
the
expose-retry-counts
branch
from
f63a71b to
592a930
Compare
|
@brian-carroll friendly ping, in case this slipped through, bc the GH plugin doesn't ping the team for non-monorepo PRs |
Oops, yeah totally missed it, sorry! |
brian-carroll
approved these changes
Feb 12, 2025
| main = Test.run tests | ||
| main = do | ||
| -- macos runners seem to be slow and fail on several kafka integration tests | ||
| System.Environment.setEnv "NRI_TEST_TIMEOUT" "240000" |
There was a problem hiding this comment.
Wow this is a lot.
I thought it was just a temporary thing while you were debugging but I see it's still there.
I guess if we need it, we need it!
How long do the tests actually take?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're exposing how many times a message has been retried to consumer subscription handlers.
This allows consumers to implement a dead letter queue.
We're exposing that only for consumers that manage their own offsets, because that's where we're building a DLQ rn. If more people want DLQs, we can do it for regular
subscribetoo.