Skip to content

Commit

Permalink
Merge pull request #1471 from NoRedInk/highlight-hover-style
Browse files Browse the repository at this point in the history
A11-3441 Prevent applying hover styles after toggling highlight
  • Loading branch information
charbelrami authored Aug 21, 2023
2 parents 5fe02d2 + 29a80f4 commit 7c65f46
Show file tree
Hide file tree
Showing 6 changed files with 1,570 additions and 4 deletions.
6 changes: 3 additions & 3 deletions component-catalog/src/Examples/Highlighter.elm
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import Nri.Ui.Colors.V1 as Colors
import Nri.Ui.Fonts.V1 as Fonts
import Nri.Ui.Heading.V3 as Heading
import Nri.Ui.Highlightable.V3 as Highlightable exposing (Highlightable)
import Nri.Ui.Highlighter.V4 as Highlighter
import Nri.Ui.Highlighter.V5 as Highlighter
import Nri.Ui.HighlighterTool.V1 as Tool
import Nri.Ui.Table.V7 as Table
import Nri.Ui.Text.V6 as Text
Expand All @@ -38,7 +38,7 @@ moduleName =

version : Int
version =
3
5


{-| -}
Expand Down Expand Up @@ -78,7 +78,7 @@ example =
, settings = state.settings
, mainType = Nothing
, extraCode =
[ "import Nri.Ui.Highlightable.V2 as Highlightable"
[ "import Nri.Ui.Highlightable.V3 as Highlightable"
, "import Nri.Ui.HighlighterTool.V1 as Tool"
]
, renderExample = Code.unstyledView
Expand Down
1 change: 1 addition & 0 deletions elm.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"Nri.Ui.Heading.V3",
"Nri.Ui.Highlightable.V3",
"Nri.Ui.Highlighter.V4",
"Nri.Ui.Highlighter.V5",
"Nri.Ui.HighlighterTool.V1",
"Nri.Ui.HighlighterToolbar.V3",
"Nri.Ui.Html.Attributes.V2",
Expand Down
3 changes: 3 additions & 0 deletions forbidden-imports.toml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ hint = 'upgrade to V4'
[forbidden."Nri.Ui.Highlighter.V3"]
hint = 'upgrade to V4'

[forbidden."Nri.Ui.Highlighter.V4"]
hint = 'upgrade to V5'

[forbidden."Nri.Ui.HighlighterToolbar.V1"]
hint = 'upgrade to V3'

Expand Down
Loading

0 comments on commit 7c65f46

Please sign in to comment.