Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip tail affixation #1477

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+1,446 −19
Draft

Tooltip tail affixation #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c90bd08
Move changes to Tooltip/V4.elm
caseyWebb Aug 22, 2023
7e58dd7
idiomatic package.json scripts
caseyWebb Aug 22, 2023
92d03be
transitive updates
caseyWebb Aug 22, 2023
c1032ad
Remove cruft
caseyWebb Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion component-catalog/src/Examples/ClickableSvg.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import Html.Styled.Attributes as Attributes
import Nri.Ui.ClickableSvg.V2 as ClickableSvg
import Nri.Ui.Colors.V1 as Colors
import Nri.Ui.Svg.V1 exposing (Svg)
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Nri.Ui.UiIcon.V1 as UiIcon


Expand Down
4 changes: 2 additions & 2 deletions component-catalog/src/Examples/Menu.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import Nri.Ui.Menu.V4 as Menu
import Nri.Ui.Spacing.V1 as Spacing
import Nri.Ui.Table.V7 as Table
import Nri.Ui.TextInput.V7 as TextInput
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Nri.Ui.UiIcon.V1 as UiIcon
import Set exposing (Set)
import Svg.Styled as Svg
Expand Down Expand Up @@ -147,7 +147,7 @@ view ellieLinkConfig state =
[ "import Nri.Ui.Button.V10 as Button"
, "import Nri.Ui.ClickableSvg.V2 as ClickableSvg"
, "import Nri.Ui.ClickableText.V3 as ClickableText"
, "import Nri.Ui.Tooltip.V3 as Tooltip"
, "import Nri.Ui.Tooltip.V4 as Tooltip"
, "\ntype Msg = ToggleMenu { focus : Maybe String, isOpen : Bool } | ToggleTooltip Bool"
]
, renderExample = Code.unstyledView
Expand Down
2 changes: 1 addition & 1 deletion component-catalog/src/Examples/SegmentedControl.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import Nri.Ui.Colors.V1 as Colors
import Nri.Ui.Fonts.V1 as Fonts
import Nri.Ui.SegmentedControl.V14 as SegmentedControl
import Nri.Ui.Svg.V1 as Svg exposing (Svg)
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Nri.Ui.UiIcon.V1 as UiIcon
import String exposing (toLower)
import Task
Expand Down
4 changes: 2 additions & 2 deletions component-catalog/src/Examples/Tabs.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import Nri.Ui.Message.V4 as Message
import Nri.Ui.Panel.V1 as Panel
import Nri.Ui.Tabs.V8 as Tabs exposing (Alignment(..), Tab)
import Nri.Ui.Text.V6 as Text
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Task


Expand Down Expand Up @@ -124,7 +124,7 @@ example =
, update = SetSettings
, settings = model.settings
, mainType = Just "RootHtml.Html { select : Int, focus : Maybe String }"
, extraCode = [ "import Nri.Ui.Tooltip.V3 as Tooltip" ]
, extraCode = [ "import Nri.Ui.Tooltip.V4 as Tooltip" ]
, renderExample = Code.unstyledView
, toExampleCode =
\_ ->
Expand Down
4 changes: 2 additions & 2 deletions component-catalog/src/Examples/Tooltip.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ import Nri.Ui.Colors.V1 as Colors
import Nri.Ui.Heading.V3 as Heading
import Nri.Ui.Svg.V1 as Svg
import Nri.Ui.Table.V7 as Table
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Nri.Ui.UiIcon.V1 as UiIcon


version : Int
version =
3
4


moduleName : String
Expand Down
1 change: 1 addition & 0 deletions elm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
"Nri.Ui.TextArea.V5",
"Nri.Ui.TextInput.V7",
"Nri.Ui.Tooltip.V3",
"Nri.Ui.Tooltip.V4",
"Nri.Ui.UiIcon.V1"
],
"elm-version": "0.19.0 <= v < 0.20.0",
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"lib/**/*.js"
],
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"start": "./script/develop.sh",
"test": "elm-test",
"prepublish": "npm run build-lib",
"build-lib": "npx browserify --entry lib/index.js --outfile dist.js",
"puppeteer": "script/puppeteer-tests.sh"
Expand Down
2 changes: 1 addition & 1 deletion src/Nri/Ui/Menu/V4.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ import Nri.Ui.Fonts.V1
import Nri.Ui.Html.Attributes.V2 as AttributesExtra
import Nri.Ui.Shadows.V1 as Shadows
import Nri.Ui.Svg.V1 as Svg
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Nri.Ui.WhenFocusLeaves.V2 as WhenFocusLeaves


Expand Down
2 changes: 1 addition & 1 deletion src/Nri/Ui/SegmentedControl/V14.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import Nri.Ui.FocusRing.V1 as FocusRing
import Nri.Ui.Fonts.V1 as Fonts
import Nri.Ui.Html.Attributes.V2 exposing (safeId)
import Nri.Ui.Svg.V1 as Svg exposing (Svg)
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import TabsInternal.V2 as TabsInternal


Expand Down
2 changes: 1 addition & 1 deletion src/Nri/Ui/SideNav/V4.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ import Nri.Ui.Html.Attributes.V2 as AttributesExtra
import Nri.Ui.Html.V3 exposing (viewJust)
import Nri.Ui.MediaQuery.V1 as MediaQuery
import Nri.Ui.Svg.V1 as Svg exposing (Svg)
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Nri.Ui.UiIcon.V1 as UiIcon


Expand Down
2 changes: 1 addition & 1 deletion src/Nri/Ui/SideNav/V5.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ import Nri.Ui.Html.Attributes.V2 as AttributesExtra
import Nri.Ui.Html.V3 exposing (viewJust)
import Nri.Ui.MediaQuery.V1 as MediaQuery
import Nri.Ui.Svg.V1 as Svg exposing (Svg)
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import Nri.Ui.UiIcon.V1 as UiIcon


Expand Down
2 changes: 1 addition & 1 deletion src/Nri/Ui/Tabs/V8.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ import Nri.Ui.Colors.V1 as Colors
import Nri.Ui.FocusRing.V1 as FocusRing
import Nri.Ui.Fonts.V1 as Fonts
import Nri.Ui.MediaQuery.V1 as MediaQuery
import Nri.Ui.Tooltip.V3 as Tooltip
import Nri.Ui.Tooltip.V4 as Tooltip
import TabsInternal.V2 as TabsInternal


Expand Down
Loading
Loading