Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHX-1075][PHX-1071] Bump to 24.6.0 to include RadioButtonDotless changes #1493

Conversation

micahhahn
Copy link
Member

@micahhahn micahhahn commented Aug 25, 2023

🏷️ Bump for version 24.6.0

What changes does this release include?

How has the API changed?

This is a MINOR change.

---- Nri.Ui.RadioButtonDotless.V1 - MINOR ----

    Added:
        disabled : msg -> Nri.Ui.RadioButtonDotless.V1.Attribute value msg
        enabled : Nri.Ui.RadioButtonDotless.V1.Attribute value msg

Releasing

After this PR merges, and you've pulled down latest master, finish following the publishing process.

@linear
Copy link

linear bot commented Aug 25, 2023

PHX-1071 Add disabled style to RadioButtonDotless

We need a disabled style for dotless radio buttons because the MC buttons are occasionally disabled (like right after a student answers).

Acceptance Criteria

PHX-1075 Shrink large `RadioButtonDotless` font size to 18px

See commentary on PHX-1025

Acceptance Criteria

  • noredink-ui is updated such that the large RadioButtonDotless buttons have a font size of 18px
  • noredink-ui version is bumped
  • new version is applied to the monorepo

@micahhahn micahhahn requested review from a team and charbelrami and removed request for a team August 25, 2023 17:21
@micahhahn micahhahn marked this pull request as ready for review August 25, 2023 17:21
@micahhahn micahhahn merged commit 614a0c0 into master Aug 28, 2023
6 checks passed
@micahhahn micahhahn deleted the phx-1075-1071-bump-noredink-ui-for-radiobuttondotless-improvements branch August 28, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants