Add elm-review rule for FocusLoop.Lazy #1536
Draft
+347
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyWebb
requested review from
a team and
charbelrami
and removed request for
a team
caseyWebb
force-pushed
the
elm-review-focus-loop-lazy
branch
from
e939327
to
75cd89f
Compare
|
I think this rule should be moved to monolith to avoid elm-review runtime dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an elm-review rule that can be used by consumers of nri-ui to ensure proper usage of
FocusLoop.Lazyper the comment inNri.Ui.FocusLoop.Lazy.V1.I'm not sure this is exactly the best place for this to live, but I'm also not sure where else it would go.