Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UiIcon.review icon #1723

Merged
merged 1 commit into from
Dec 10, 2024
Merged

add UiIcon.review icon #1723

merged 1 commit into from
Dec 10, 2024

Conversation

juanedi
Copy link
Member

@juanedi juanedi commented Dec 10, 2024

Context

Adds an icon for the confirmation modal leading to the new "review" step in writing assignments.

Part of QUO-1108.

🖼️ What does this change look like?

Screenshot 2024-12-10 at 10 59 38 AM

Component completion checklist

  • I've gone through the relevant sections of the Development Accessibility guide with the changes I made to this component in mind
  • Changes are clearly documented
    • Component docs include a changelog
    • Any new exposed functions or properties have docs
  • Changes extend to the Component Catalog
    • The Component Catalog is updated to use the newest version, if appropriate
    • The Component Catalog example version number is updated, if appropriate
    • Any new customizations are available from the Component Catalog
    • The component example still has:
      • an accurate preview
      • valid sample code
      • correct keyboard behavior
      • correct and comprehensive guidance around how to use the component
  • Changes to the component are tested/the new version of the component is tested
  • Component API follows standard patterns in noredink-ui
    • e.g., as a dev, I can conveniently add an nriDescription
    • and adding a new feature to the component will not require major API changes to the component
  • If this is a new major version of the component, our team has stories created to upgrade all instances of the old component. Here are links to the stories:
    • add your story links here OR just write this is not a new major version
  • Please assign the following reviewers:
    • Someone from your team who can review your PR in full and review requirements from your team's perspective.
    • Component library owner - Someone from this group will review your PR for accessibility and adherence to component library foundations.
    • If there are user-facing changes, a designer. (You may want to direct your designer to the deploy preview for easy review):
      • For writing-related component changes, add Stacey (staceyadams)
      • For quiz engine-related components, add Ravi (ravi-morbia)
      • For a11y-related changes to general components, add Ben (bendansby)
      • For general component-related changes or if you’re not sure about something, add the Design group (NoRedInk/design)

Copy link

linear bot commented Dec 10, 2024

Copy link
Contributor

@ArthurJordao ArthurJordao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanedi thank you! btw, do you have a script that converts from svg to elm or did you do it manually?

@juanedi
Copy link
Member Author

juanedi commented Dec 10, 2024

@juanedi thank you! btw, do you have a script that converts from svg to elm or did you do it manually?

A comment at the top of Nri.Ui.UiIcon.V1 pointed me to this doc, which pointed me to this website. Then it suggests running a script in our repo to adjust some of the namespaces/imports.

I had to make a few manual tweaks, but nothing huge.

@juanedi juanedi added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit af82c43 Dec 10, 2024
8 checks passed
@juanedi juanedi deleted the add-review-icon branch December 10, 2024 18:17
@ArthurJordao
Copy link
Contributor

@juanedi so nice

@ArthurJordao
Copy link
Contributor

@rekahsoft about what we talked a while ago :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants