Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macos-12 to macos-13 (latest macos to still support intel). #730

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

nebasuke
Copy link
Member

@nebasuke nebasuke commented Nov 18, 2024

GitHub runner deprecated macos-12 (see actions/runner-images#10721). macos-13 is the latest image to still support x86.

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 3d9209f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nebasuke nebasuke temporarily deployed to github-action-benchmark November 18, 2024 16:10 — with GitHub Actions Inactive
@nebasuke nebasuke added the no changeset needed This PR doesn't require a changeset label Nov 18, 2024
@nebasuke
Copy link
Member Author

nebasuke commented Nov 18, 2024

Release commit using the update to macos-13 passed in #729 (see run https://github.com/NomicFoundation/edr/actions/runs/11896189854/), so I am comfortable merging this now.

@nebasuke nebasuke added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit f831d16 Nov 18, 2024
37 of 38 checks passed
@nebasuke nebasuke deleted the bas-macos13 branch November 18, 2024 16:44
@MHatemAbdelhamid
Copy link

my azure release was working fine till yesterday, I run now I am getting
##[Error 1]
The macOS-12 environment is deprecated, consider switching to macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see actions/runner-images#10721

it seems it's relevant to this issue

is this a bug or I need to add a capability or something to my Agent?

@nebasuke
Copy link
Member Author

@MHatemAbdelhamid Please check actions/runner-images#10721, which includes the ways of mitigation. This is the repository for the Ethereum Development Runtime.

If you're curious to see how I tackled the changes needed for the EDR repo, you can check the files changed. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants