Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ramp up slang features for vscode users #546

Open
4 of 6 tasks
OmarTawfik opened this issue Mar 13, 2024 · 3 comments · Fixed by #597
Open
4 of 6 tasks

ramp up slang features for vscode users #546

OmarTawfik opened this issue Mar 13, 2024 · 3 comments · Fixed by #597
Assignees
@OmarTawfik
Labels
status:ready This issue is ready to be worked on

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Mar 13, 2024 •
edited
Loading

  • Ship a new extension version, including the Slang binaries.
  • Ramping up flags.json settings introduced in Semantic highlight and document symbols on slang 0.10 #523 to 100% gradually.
  • Observing any errors/telemetry issues in Sentry, and report/fix as-needed.
  • Report any Slang issues, and integrate fixes as they are released.
  • Remove the isSlangSupported utility, and ship an extension that unconditionally enables the features.
  • Remove flags.json and clean up the code that uses it.

cc @Xanewok as the extension was recently upgraded to the latest Slang version in #545
@OmarTawfik OmarTawfik mentioned this issue Mar 13, 2024
Closed
6 tasks
@Xanewok Xanewok mentioned this issue Mar 28, 2024
Merged
github-merge-queue bot pushed a commit to NomicFoundation/slang that referenced this issue Apr 8, 2024
@Xanewok
fix: Ensure that Node.js native addon targets GLIBC 2.28 on `x86_64-u…
cdcdf8c 
…nknown-linux-gnu` (#909)

Required for
NomicFoundation/hardhat-vscode#546 #639

Without this, we host-compiled our native addon with the GLIBC of the
runner (`ubuntu-22.04`), which is 2.33. That's too high and will cause
linking issues on older, stable distributions such as Debian 11 (2.31),
Debian 10 (2.28), Ubuntu 20.04 (2.31) etc.

The Linux requirement for VS Code atm is 2.28
(https://code.visualstudio.com/docs/supporting/requirements#_additional-linux-requirements)
and was bumped in [1.86](https://code.visualstudio.com/updates/v1_86).
Prior to that, the required version was 2.17 and we might consider
targeting it instead, until we bump the required VS Code engine for the
shipped extension (cc @kanej).

Here is the latest runs that check that the `infra publish npm
--dry-run` executes as expected and passes the relevant checks on our
CI:
https://github.com/Xanewok/slang/actions/runs/8472800732/job/23215682564.
The built artifacts are uploaded as part of the pipeline so they can be
additionally downloaded and inspected manually for the GLIBC symbols.
@Xanewok Xanewok removed their assignment May 17, 2024
@OmarTawfik OmarTawfik assigned OmarTawfik and unassigned antico5 Jul 26, 2024
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Jul 29, 2024
@fvictorio
Copy link
Member

@OmarTawfik should we close this one?

@OmarTawfik OmarTawfik linked a pull request Sep 16, 2024 that will close this issue
set Slang release flags to 100% #597
Merged
@OmarTawfik
Copy link
Contributor Author

O

@OmarTawfik OmarTawfik reopened this Sep 16, 2024
@OmarTawfik
Copy link
Contributor Author

Looking into this, I suggest keeping it open until we eventually remove the flags.json usage and release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmarTawfik OmarTawfik

Labels
status:ready This issue is ready to be worked on
Projects
Slang - 2024 H2
Status: ⏳ Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set Slang release flags to 100% NomicFoundation/hardhat-vscode
5 participants
@kanej @fvictorio @antico5 @Xanewok @OmarTawfik