Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set Slang release flags to 100% #597

Merged
merged 1 commit into from
Sep 2, 2024
Merged

set Slang release flags to 100% #597

merged 1 commit into from
Sep 2, 2024

Conversation

OmarTawfik
Copy link
Contributor

No new issues or bug reports. Let's do it 🚀

Btw, I noticed that the terminology in the file is now a bit confusing. percent: 1 reads like 1% rather than 100% 🤔 but I don't think it is worth the risk to change it now, considering the implications for existing/older versions still running.

No new issues or bug reports. Let's do it 🚀

Btw, I noticed that the terminology in the file is now a bit confusing. `percent: 1` reads like 1% rather than 100% 🤔 but I don't think it is worth the risk to change it now, considering the implications for existing/older versions still running.
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OmarTawfik OmarTawfik merged commit 1ba5fc4 into development Sep 2, 2024
11 of 12 checks passed
@OmarTawfik OmarTawfik deleted the slang-flags-100 branch September 2, 2024 11:03
@OmarTawfik OmarTawfik linked an issue Sep 16, 2024 that may be closed by this pull request
6 tasks
OmarTawfik added a commit that referenced this pull request Sep 26, 2024
No new issues or bug reports. Let's do it 🚀

Btw, I noticed that the terminology in the file is now a bit confusing. `percent: 1` reads like 1% rather than 100% 🤔 but I don't think it is worth the risk to change it now, considering the implications for existing/older versions still running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ramp up slang features for vscode users
2 participants