-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate ignition-core to Hardhat 3 #6195
base: v-next
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4f3cf66
to
8925350
Compare
hardhatTotal size of the bundle: List of dependencies (sorted by size)
|
8925350
to
58fe088
Compare
58fe088
to
1a56ee6
Compare
fd66b53
to
b27f434
Compare
b27f434
to
daf6d18
Compare
77627fe
to
fcac323
Compare
fcac323
to
ecdd3f8
Compare
ecdd3f8
to
67b1746
Compare
67b1746
to
9191620
Compare
We will bring these back when we have Hardhat 3 as a proper dependency.
Remove the dep on fs-extra to avoid trying to figure out how to ESM the usage.
This is to avoid asyncing every function.
Add a format property to mimic the Hardhat version. This allows us to not rely directly on the Hardhat artifact type from `core`.
We were pulling in Artifact for testing, and HRE for testing. I have left a todo to rewire HRE setup to a proper type.
We work around asyncing up the chain by directly importing the specific function.
We don't actually have access to HRE. We will bring it back later.
We are holding on pulling in the hardhat-utils version for the moment.
`cbor` is deprecated and commonjs.
The readFile changes to util changed the error returned. An assertion (flow control throw exceptions booooo) guard had to be changed to match the new error found.
cc9a9e8
to
e68811e
Compare
This should be temporary. To run mocha with the latest tsconfig, we override the tsconfig rules via an env variable. For this to work with windows we are using `cross-env`. This should be removed when we port to Node Test Runner.
Bring all `v-next` packages into line on the latest `ethers`.
Bring all v-next packages into line on ^4.1.7 for `@types/debug`.
This brings all the `v-next` packages on to the latest.
Bring the `v-next` version inline with Ignition.
This involved moving the Ignition version down.
Hardhat was referring to the Hardhat 2 package. We are using new eslint rules.
We will add it back in with the port to Node Test Runner for tests.
e68811e
to
d278dbc
Compare
Migrate
@nomicfoundation/ignition-core
to Hardhat 3.We move all of Ignition's packages under
./packages
to a./tmp-ignition
folder, taking Ignition out of the build. We then bringignition-core
underv-next
, make it support ESM and wire it into the Hardhat 3 setup more generally.Resolves #6207.
Approach
ignition-core
files under./v-next
pnpm run test
) until all are passing (retaining mocha for the moment)pnpm run test:integrations
) until all are passing (retaining mocha for the moment)TODO
ignition-core
tov-next
folder with working build (but not tests)defineProperty
for inspect pattern while support isolated declarations__dirname
usagehardhat-utils
cbor
withcbor2
v-next
conventionFollow up tasks
hardhat-utils
hardhat-utils
hardhat-utils
./src/index.js
to be more specific (we should avoid relying onindex.js files)
hardhat-chai-matchers