Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanctuary grammar fixes #1246

Merged
merged 2 commits into from
Feb 11, 2025
Merged

sanctuary grammar fixes #1246

merged 2 commits into from
Feb 11, 2025

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Feb 10, 2025 •
edited
Loading

  • make sure super and this keywords are unreserved before 0.8.0
  • enable yul's true and false keywords starting from 0.6.2
  • make sure assembly flags are only enabled starting from 0.8.13
  • unreserve jump and jumpi yul keywords between 0.6.0 and 0.8.0

@OmarTawfik OmarTawfik marked this pull request as ready for review February 10, 2025 19:00
@OmarTawfik OmarTawfik requested review from a team as code owners February 10, 2025 19:00
@OmarTawfik OmarTawfik enabled auto-merge February 10, 2025 19:00
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 47f7417

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/slang Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

beta-ziliani
beta-ziliani approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: This PR also removes two problematic chains from sanctuary, and introduce a refactor to the solc compliance test.

@OmarTawfik OmarTawfik added this pull request to the merge queue Feb 11, 2025
Merged via the queue into NomicFoundation:main with commit aea2dd0 Feb 11, 2025
1 check passed
@OmarTawfik OmarTawfik deleted the sanctuary-fixes branch February 11, 2025 13:04
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @beta-ziliani