Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement workaround for fuel tooltip log spam bug #25

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Implement workaround for fuel tooltip log spam bug #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9edf024
Implement workaround for fuel log spam bug
Exaxxion Jun 1, 2021
6b1477c
Remove short-circuiting dimension check logic
Exaxxion Jun 2, 2021
b41e5fd
Revert inadvertent static imports change
Exaxxion Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/main/java/jackyy/dimensionaledibles/block/BlockCustomCake.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import jackyy.dimensionaledibles.item.*;
import jackyy.dimensionaledibles.registry.*;
import jackyy.dimensionaledibles.util.*;
import mcjty.theoneprobe.api.*;
import mcp.mobius.waila.api.*;
import net.minecraft.block.*;
import net.minecraft.block.state.*;
import net.minecraft.creativetab.*;
Expand All @@ -20,6 +22,8 @@

import javax.annotation.*;

import java.util.*;

import static jackyy.dimensionaledibles.DimensionalEdibles.logger;
import static net.minecraftforge.common.DimensionManager.isDimensionRegistered;

Expand Down Expand Up @@ -222,4 +226,29 @@ public ModConfig.CustomCoords customCoords(int dim) {
@Override
@Nonnull
public ItemStack defaultFuel() { return ItemStack.EMPTY; }

/*
These overrides work around the bug causing log spam in tooltips when
looking at a cake. We should still consider splitting up custom cakes
into separate objects per dimension as hot-swapping state is brittle.
*/
@Override
public void addProbeInfo(ProbeMode mode,
IProbeInfo probeInfo,
EntityPlayer player,
World world,
IBlockState blockState,
IProbeHitData data) {
this.cakeDimension = getDimension(world, data.getPos());
super.addProbeInfo(mode, probeInfo, player, world, blockState, data);
}

@Override
public List<String> getWailaBody(ItemStack itemStack,
List<String> currentTip,
IWailaDataAccessor accessor,
IWailaConfigHandler config) {
this.cakeDimension = getDimension(accessor.getWorld(), accessor.getPosition());
return super.getWailaBody(itemStack, currentTip, accessor, config);
}
}