Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused jl_stdout_obj import since it was removed in Julia 1.11 #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JackDunnNZ
Copy link
Contributor

This jl_stdout_obj doesn't seem to be used anywhere in the package, and was removed in Julia 1.11: JuliaLang/julia#53250

Fixes #234

@schlichtanders
Copy link

Looking forward to get this merged! Currently RCall blocks me from transitioning to Julia 1.11

@schlichtanders
Copy link

@JackDunnNZ thank you for you work. What is needed to get this merged? I am really blocked by this and would like to speed up the process if possible

@cderv
Copy link

cderv commented Oct 21, 2024

I believe we are all in wait of

And a discussion on what to do next should happen there.

Other PR like #210 are opened since more than 1 year with no reaction.

@PallHaraldsson
Copy link

PallHaraldsson commented Oct 22, 2024

bump. [My alternative suggestion is at JuliaLang, (partial) revert of the breaking change there.]

If this wasn't actually used, can't this be speedily merged? And presumably solving the problem (on master; and then tag a new version?).

@JackDunnNZ
Copy link
Contributor Author

bump.

If this wasn't actually used, can't this be speedily merged? And presumably solving the problem (on master; and then tag a new version?).

Please read the issue linked above, @Non-Contradiction is unfortunately nowhere to be found

@PallHaraldsson
Copy link

PallHaraldsson commented Oct 22, 2024

I did and I realize @Non-Contradiction is absent, maybe only one(?) with merge access. I would be willing to fix this (get maintainer status), I see you @JackDunnNZ have some commits, presumably no access (nor any other contributor), why I also edited, mentioning my alternative at JulaLang.

It's bad that 1.11 broke this (possibly it wasn't documented API), though understandable PkgEval didn't catch (and thus probably thought ok); see issue I linked and commented on.

@JackDunnNZ
Copy link
Contributor Author

Yes, unfortunately I have no commit access - I am merely an invested user that fixes things each time they have broken :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

juliacall fails in julia 1.11 with undefined symbol: jl_stdout_obj
4 participants