fix use-after-free bug

Signed-off-by: Leonardo Sarra <[email protected]>
Nordix · Aug 5, 2024 · a16f357 · a16f357
1 parent 9db18bc
commit a16f357
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/source/common/router/router.cc b/source/common/router/router.cc
@@ -580,10 +580,10 @@ Http::FilterHeadersStatus Filter::decodeHeaders(Http::RequestHeaderMap& headers,
       (upstream_http_protocol_options.value().auto_sni() ||
        upstream_http_protocol_options.value().auto_san_validation())) {
     // Default the header to Host/Authority header.
-    auto header_value = headers.getHostValue();
-    if (Runtime::runtimeFeatureEnabled(
+    std::string header_value = route_entry_->getRequestHostValue(headers);
+    if (!Runtime::runtimeFeatureEnabled(
             "envoy.reloadable_features.use_route_host_mutation_for_auto_sni")) {
-      header_value = route_entry_->getRequestHostValue(headers);
+      header_value = std::string(headers.getHostValue());
     }
 
     // Check whether `override_auto_sni_header` is specified.