cran comments

NEWS.md

@@ -1,5 +1,6 @@
 # shapr 1.0.1 
 
+* Spelling checking and other minor clean up [#431](https://github.com/NorskRegnesentral/shapr/pull/431))
 * Add extra_computation_args and output_args to explain_forecast() [#428](https://github.com/NorskRegnesentral/shapr/pull/428))
 * Rename vaeac plotting functions [#428](https://github.com/NorskRegnesentral/shapr/pull/428))
 * Move explain() arguments `paired_shap_sampling` and `kernelSHAP_reweighting` into `extra_computation_args` [#428](https://github.com/NorskRegnesentral/shapr/pull/428))

cran-comments.md

@@ -25,7 +25,7 @@ The win-builder and R-hub tests are run without snapshots tests (to replicate CR
 
 There were no ERRORs or WARNINGs
 
-There were X NOTES
+There were 3 NOTES
 
 ### NOTE 1 (on win-builder (oldrelease)):
 
@@ -34,70 +34,49 @@ Possibly misspelled words in DESCRIPTION:
 
 > This refers to the Python wrapper of the package and is not misspelled.
 
-## Downstream dependencies
-There is 2 downstream dependency (PPtreeregViz, SEMdeep) of shapr. In addition, the package shapviz provides additional
-plotting functionality without stating an explicit dependency (I believe shapr actually should have be listed under 
-Suggests?)
-All packages fails on R CMD checks, but I have submitted PRs to fix the issues.
-
-### PPtreeregViz
-
-* Nov 26th 2024 I submitted a PR fixing the issue: https://github.com/sunsmiling/PPtreeregViz/pull/2
-There has been no reaction from the maintainer
-
-### SEMdeep
+### NOTE 2 (on win-builder (release)):
 
-* Nov 15th 2024 I submitted a PR fixing the issue: https://github.com/BarbaraTarantino/SEMdeep/pull/1
-There has been no reaction from the maintainer.
-
-### shapviz
-
-* Nov 15th 2024 I submitted a PR fixing the issue: https://github.com/ModelOriented/shapviz/pull/162
-The PR was merged to the GitHub version on Nov 16th 2024. The CRAN version has naturally not been updated yet.
-I will notify the maintainer when the new version of shapr is released on CRAN.
+Examples with CPU (user + system) or elapsed time > 10s
+         user system elapsed
+explain 10.33   0.44   10.77
 
+> Although very limited, the examples requires some time to run as the computations are expensive.
 
 
-
-################### TO BE DELETED IN THE END ###############
+### NOTE 3 (multiple platforms):
 
 * checking installed package size ... NOTE
-  installed size is  5.0Mb
+  installed size is  8.0Mb
   sub-directories of 1Mb or more:
-    libs   4.0Mb
-
-> Nothing has changed since the last submission.
+    doc    4.4Mb
+    libs   1.3Mb
 
+> The package is growing in size, uses more complied code, and the documentation is comprehensive
 
 
-### NOTE 2 (on R-hub (Fedora Linux)):
+## Downstream dependencies
+There is 2 downstream dependency (`PPtreeregViz`, `SEMdeep`) of `shapr`. 
+In addition, the package `shapviz` provides additional plotting functionality without stating an explicit dependency 
+(I believe shapr actually should have be listed under Suggests?)
 
-* checking HTML version of manual ... NOTE
-Skipping checking HTML validation: no command 'tidy' found
-Skipping checking math rendering: package 'V8' unavailable
+The 3 packages fails on R CMD checks, but I have submitted PRs to fix all issues.
 
-> Missing packages on R-hubs Windows Server 2022 platform.
+### PPtreeregViz
 
-### NOTE 4 (on R-hub (Fedora Linux, Windows Server 2022)):
+* Nov 26th 2024 I submitted a PR fixing the issue: https://github.com/sunsmiling/PPtreeregViz/pull/2
+There has been no reaction from the maintainer.
 
-*Found the following (possibly) invalid URLs:
-  URL: https://opensource.org/license/mit/
-    From: README.md
-    Status: 403
-    Message: Forbidden
+### SEMdeep
 
-> I believe this is a false positive. Running 'urlchecker::url_check()' locally shows all URLs are correct.
+* Nov 15th 2024 I submitted a PR fixing the issue: https://github.com/BarbaraTarantino/SEMdeep/pull/1
+There has been no reaction from the maintainer.
 
-### NOTE 5 (on R-hub (Windows Server 2022)):
+### shapviz
 
-* checking for detritus in the temp directory ... NOTE
-Found the following files/directories:
-  'lastMiKTeXException'
+* Nov 15th 2024 I submitted a PR fixing the issue: https://github.com/ModelOriented/shapviz/pull/162
+The PR was merged to the GitHub version on Nov 16th 2024. The CRAN version has naturally not been updated yet.
+I will notify the maintainer when the new version of `shapr` is released on CRAN.
 
-> As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this could be due to a bug/crash in MiKTeX and can likely be ignored.
 
-## Downstream dependencies
-There is 1 downstream dependency (PPtreeregViz) of shapr
-I have also run R CMD check on that and it passed without errors, warnings or notes.