Include paired combination sampling #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHBO
commented
Dec 4, 2023
R/explain_forecast.R
Outdated
| @@ -94,6 +94,7 @@ explain_forecast <- function(model, | |||
| approach, | |||
| prediction_zero, | |||
| n_combinations = NULL, | |||
| combination_sampling_method = "unique", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed the PR, as this has been implemented as part of shapr version 1.0.0 in #402 .
In this pull request, we add support for including paired combination sampling as an option when using a sampled subset of combinations to compute the Shapley value explanations. The user can specify whether he/she wants to use
unique(default before, and still default),unique-paired(new), ornon-unique(default in very old version ofshapr).Paired sampling has been shown to improve the precision of the approximated Shapley value explanations in several papers., see e.g., (https://arxiv.org/abs/2107.07436).
In my own simulation studies, I found it beneficial to use paired sampling when the features were correlated, but I saw no improvement for independent features.